Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: backport v2 changelog sections to main #1433

Merged
merged 1 commit into from
Nov 21, 2023
Merged

docs: backport v2 changelog sections to main #1433

merged 1 commit into from
Nov 21, 2023

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Nov 15, 2023

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct docs: prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct docs: prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR only changes documentation
  • Reviewed content for consistency
  • Reviewed content for spelling and grammar
  • Tested instructions (if applicable)
  • Checked that the documentation website can be built and deployed successfully (run make build-docs)

@mpoke mpoke requested a review from a team as a code owner November 15, 2023 17:09
p-offtermatt
p-offtermatt approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But just checking, the name of these should indeed contain -provider, because these were named before the recent change to the naming convention, is that correct?

@sainoe sainoe merged commit 81331b4 into main Nov 21, 2023
14 checks passed
@sainoe sainoe deleted the marius/backport-v2-changelog branch November 21, 2023 09:15
MSalopek pushed a commit that referenced this pull request Dec 1, 2023
@mpoke @MSalopek
docs: backport v2 changelog sections to main (#1433)
f0aaa2a 
backport v2 changelog sections to main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-offtermatt p-offtermatt p-offtermatt approved these changes

@sainoe sainoe sainoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpoke @sainoe @p-offtermatt